Fix int literal#3399
Merged
sobolevn merged 20 commits intowemake-services:masterfrom May 3, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3399 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 362 362
Lines 11905 11921 +16
Branches 814 815 +1
=========================================
+ Hits 11905 11921 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sobolevn
reviewed
Apr 24, 2025
Member
sobolevn
left a comment
There was a problem hiding this comment.
Thank you! Please, also add a changelog entry
sobolevn
reviewed
Apr 29, 2025
sobolevn
reviewed
May 1, 2025
| or is_non_magic | ||
| or self._check_is_number_in_typing_literal(parent) | ||
| or check_is_node_in_specific_annotation( | ||
| parent, 'Literal', {'typing', 'typing_extensions'} |
Member
There was a problem hiding this comment.
Please, move {'typing', 'typing_extensions'} to class level and make it a frozenset
sobolevn
approved these changes
May 3, 2025
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3397