Skip to content

Issue 3350: fix WPS221 being too strict with f-strings#3356

Merged
sobolevn merged 5 commits intowemake-services:masterfrom
Tapeline:issue-3350
Mar 25, 2025
Merged

Issue 3350: fix WPS221 being too strict with f-strings#3356
sobolevn merged 5 commits intowemake-services:masterfrom
Tapeline:issue-3350

Conversation

@Tapeline
Copy link
Copy Markdown
Contributor

I have made things!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Related issues

🙏 Please, if you or your company is finding wemake-python-styleguide valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/wemake-python-styleguide. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6ea1da5) to head (bd1cf1f).
Report is 98 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3356   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          361       361           
  Lines        11814     11815    +1     
  Branches       805       805           
=========================================
+ Hits         11814     11815    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one question :)

(line_with_comprehension, 6),
(line_with_math, 9),
(regression1216, 15),
(regression3350, 10),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What it used to be?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't fully understand your question. You mean what [the old jones complexity] used to be? If I remember correctly, somewhere around 17. Do I need to mention that information somewhere?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please, in a comment :)

Copy link
Copy Markdown
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit 98a9118 into wemake-services:master Mar 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WPS221 (line Jones complexity) is overly strict with f-strings

2 participants