Issue 3265: Add WPS476 SneakyTypeVarWithDefaultViolation#3314
Merged
sobolevn merged 39 commits intowemake-services:masterfrom Mar 15, 2025
Merged
Issue 3265: Add WPS476 SneakyTypeVarWithDefaultViolation#3314sobolevn merged 39 commits intowemake-services:masterfrom
sobolevn merged 39 commits intowemake-services:masterfrom
Conversation
…thDefaultViolation and corresponding tests
# Conflicts: # wemake_python_styleguide/visitors/ast/classes.py
# Conflicts: # tests/test_visitors/test_ast/test_classes/test_type_var_with_default.py
sobolevn
reviewed
Feb 20, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3314 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 358 361 +3
Lines 11761 11814 +53
Branches 803 805 +2
=========================================
+ Hits 11761 11814 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sobolevn
reviewed
Feb 27, 2025
Comment on lines
+37
to
+39
| IGNORED_VIOLATIONS3_13 = ( | ||
|
|
||
| ) |
Member
There was a problem hiding this comment.
Suggested change
| IGNORED_VIOLATIONS3_13 = ( | |
| ) | |
| IGNORED_VIOLATIONS3_13 = () |
Comment on lines
+302
to
+306
| SHOULD_BE_RAISED3_13 = types.MappingProxyType( | ||
| dict.fromkeys(SHOULD_BE_RAISED, 0) | { | ||
| 'WPS476': 1 | ||
| } | ||
| ) |
Member
There was a problem hiding this comment.
Suggested change
| SHOULD_BE_RAISED3_13 = types.MappingProxyType( | |
| dict.fromkeys(SHOULD_BE_RAISED, 0) | { | |
| 'WPS476': 1 | |
| } | |
| ) | |
| SHOULD_BE_RAISED3_13 = types.MappingProxyType( | |
| { | |
| 'WPS476': 1 | |
| } | |
| ) |
Let's simplify this case.
Contributor
Author
There was a problem hiding this comment.
Testcases check that every violation code is defined in such dictionary, so I was forced to add that line. Formatter ate my comment on this, btw
Member
There was a problem hiding this comment.
| 'class_header', | ||
| [ | ||
| ( | ||
| "T = TypeVar('T')\n" |
Member
There was a problem hiding this comment.
Please, move multiline example to variables, it is easier to read.
Contributor
Author
There was a problem hiding this comment.
The whole list, or each individual example to its variable?
Member
There was a problem hiding this comment.
we use examples like this:
wrong_type_var_defaults = """
T = TypeVar('T')
# ...
"""# Conflicts: # tests/test_visitors/test_ast/test_classes/test_type_var_with_default.py
# Conflicts: # poetry.lock
sobolevn
reviewed
Mar 9, 2025
Member
sobolevn
left a comment
There was a problem hiding this comment.
Almost ready! Just tests to fix :)
| ): | ||
| """Test that WPS476 works correctly.""" | ||
| src = ( | ||
| f'{classes_with_various_bases}\n' |
Member
There was a problem hiding this comment.
Why do we need this line here? It should be a separate test.
Contributor
Author
There was a problem hiding this comment.
Removed this line, because it's included in test_type_var_ignored testcase
sobolevn
reviewed
Mar 10, 2025
# Conflicts: # CHANGELOG.md # poetry.lock # tests/test_checker/test_noqa.py # wemake_python_styleguide/violations/best_practices.py
# Conflicts: # tests/test_visitors/test_ast/test_classes/test_type_var_with_default313.py
sobolevn
reviewed
Mar 12, 2025
sobolevn
approved these changes
Mar 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made things!
Checklist
CHANGELOG.mdRelated issues
TypeVarTupleafterTypeVarwith a default #3265Note
Making of this feature resulted into a refactoring of
visitors.ast.classesfollowing the complexity waterfall. Thorough checking is required🙏 Please, if you or your company is finding wemake-python-styleguide valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/wemake-python-styleguide. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.