Skip to content

Issue 3292: fix WPS605 false-positive on @staticmethod usage#3294

Merged
sobolevn merged 8 commits intowemake-services:masterfrom
kekekekule:issue-3292-fix
Jan 30, 2025
Merged

Issue 3292: fix WPS605 false-positive on @staticmethod usage#3294
sobolevn merged 8 commits intowemake-services:masterfrom
kekekekule:issue-3292-fix

Conversation

@kekekekule
Copy link
Copy Markdown
Contributor

@kekekekule kekekekule commented Jan 30, 2025

I have made things!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Related issues

Closes #3292

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dffbb62) to head (8869989).
Report is 98 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #3294   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          357       357           
  Lines        11696     11703    +7     
  Branches       800       801    +1     
=========================================
+ Hits         11696     11703    +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sobolevn
sobolevn reviewed Jan 30, 2025
View reviewed changes
Comment thread tests/test_visitors/test_ast/test_classes/test_methods/test_method_without_arguments.py Outdated
Comment thread tests/test_visitors/test_ast/test_classes/test_methods/test_method_without_arguments.py Outdated
Comment thread wemake_python_styleguide/violations/oop.py Outdated
Comment thread wemake_python_styleguide/violations/oop.py Outdated
Comment thread wemake_python_styleguide/visitors/ast/classes.py Outdated
kekekekule and others added 5 commits January 30, 2025 14:19
@kekekekule @sobolevn
Update tests/test_visitors/test_ast/test_classes/test_methods/test_me…
bc734e7 
…thod_without_arguments.py

Co-authored-by: sobolevn <mail@sobolevn.me>
@kekekekule @sobolevn
Update tests/test_visitors/test_ast/test_classes/test_methods/test_me…
c3eea10 
…thod_without_arguments.py

Co-authored-by: sobolevn <mail@sobolevn.me>
@kekekekule @sobolevn
Update wemake_python_styleguide/violations/oop.py
b72ae24 
Co-authored-by: sobolevn <mail@sobolevn.me>
@kekekekule @sobolevn
Update wemake_python_styleguide/visitors/ast/classes.py
1e191fe 
Co-authored-by: sobolevn <mail@sobolevn.me>
@kekekekule @sobolevn
Update wemake_python_styleguide/violations/oop.py
2afdc18 
Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn
sobolevn approved these changes Jan 30, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment thread wemake_python_styleguide/violations/oop.py
@sobolevn sobolevn merged commit ec56951 into wemake-services:master Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WPS605 rule does not take into account a @staticmethod decorator

2 participants

@kekekekule @sobolevn