Adds WPS242 which forbids to have too many cases in match block#3218
Merged
sobolevn merged 4 commits intowemake-services:masterfrom Dec 24, 2024
Merged
Adds WPS242 which forbids to have too many cases in match block#3218sobolevn merged 4 commits intowemake-services:masterfrom
WPS242 which forbids to have too many cases in match block#3218sobolevn merged 4 commits intowemake-services:masterfrom
Conversation
WPS242 which forbids to have too many cases in match block
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3218 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 367 368 +1
Lines 12370 12407 +37
Branches 865 866 +1
=========================================
+ Hits 12370 12407 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sobolevn
reviewed
Dec 24, 2024
Member
sobolevn
left a comment
There was a problem hiding this comment.
Thank you! Just one comment from my side :)
| 'WPS239': 1, | ||
| 'WPS240': 0, # only triggers on 3.12+ | ||
| 'WPS241': 1, | ||
| 'WPS242': 0, |
Member
There was a problem hiding this comment.
please, add at least one to noqa.py. we need this to:
- make sure that
noqaworks for the correct node - the whole integration process worked
Contributor
Author
There was a problem hiding this comment.
oh, i`ve missed that, sorry.
Fixed ( doesn't really fixed yet)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made things!
Checklist
CHANGELOG.mdRelated issues
casestatements #3202