chore: update linting & style facility#387
Merged
sobolevn merged 11 commits intowemake-services:masterfrom May 15, 2025
Merged
Conversation
joscha
commented
May 14, 2025
| @@ -0,0 +1,55 @@ | |||
| repos: | |||
Contributor
Author
There was a problem hiding this comment.
joscha
commented
May 14, 2025
joscha
commented
May 14, 2025
joscha
commented
May 14, 2025
joscha
commented
May 14, 2025
joscha
commented
May 14, 2025
| wemake-python-styleguide = ">=0.18,<0.20" | ||
| flake8-pytest-style = ">=1.5,<3.0" | ||
| nitpick = "^0.35" | ||
| wemake-python-styleguide = "^1.1" |
Contributor
Author
There was a problem hiding this comment.
copied verbatim from https://github.com/wemake-services/dotenv-linter/blob/master/pyproject.toml
joscha
commented
May 14, 2025
…dump-env into joscha/use-pre-commit-and-others
joscha
commented
May 14, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #387 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 83 85 +2
Branches 18 15 -3
=========================================
+ Hits 83 85 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@sobolevn PTAL |
4 tasks
joscha
commented
May 14, 2025
joscha
commented
May 14, 2025
| # Only prefix should be changed, other parts should not: | ||
| assert dump_result['DJANGO_SECRET_KEY'] == 'test' | ||
| assert dump_result['SECRET_VALUE'] == 'value' | ||
| assert dump_result['DJANGO_SECRET_KEY'] == 'test' # noqa: S105 |
Contributor
Author
There was a problem hiding this comment.
after #385 we could use syrupy for dump_result and then also get rid of the S105 directive overrides
sobolevn
reviewed
May 15, 2025
Member
sobolevn
left a comment
There was a problem hiding this comment.
Thank you so much! Several minor comments :)
Member
|
Testing |
…dump-env into joscha/use-pre-commit-and-others
Contributor
Author
|
seems to be all good \o/ |
sobolevn
approved these changes
May 15, 2025
| ignore-path = docs/_build | ||
| max-line-length = 80 | ||
| sphinx = true | ||
| [codespell] |
Member
There was a problem hiding this comment.
I think that we can remove it as well in later PRs.
| # Only prefix should be changed, other parts should not: | ||
| assert dump_result['DJANGO_SECRET_KEY'] == 'test' | ||
| assert dump_result['SECRET_VALUE'] == 'value' | ||
| assert dump_result['DJANGO_SECRET_KEY'] == 'test' # noqa: S105 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blocks #385