Skip to content

Stop picking the catch-all JoinKinds instance if arguments match#439

Merged
arybczak merged 1 commit intomasterfrom
better-join-kinds
Dec 7, 2021
Merged

Stop picking the catch-all JoinKinds instance if arguments match#439
arybczak merged 1 commit intomasterfrom
better-join-kinds

Conversation

@arybczak
Copy link
Copy Markdown
Collaborator

@arybczak arybczak commented Dec 6, 2021

Fixes #423 (to an extent).

Simpler than #424, but should make the situation strictly better.

@arybczak
Copy link
Copy Markdown
Collaborator Author

arybczak commented Dec 6, 2021

Uh, the fragility of these inspection tests is rather sad.

I also removed the let res :: JoinKinds A_Lens A_Prism k => Proxy k; res = Proxy doctest from the Optics module because it started triggering a warning with this PR. It's fixable for older GHCs, but it no longer works as expected with GHC 9.2 anyway (the constraint stays unresolved).

, leftpad $ show k
, leftpad $ show l
, leftpad $ show m
, "k"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever :)

@arybczak arybczak merged commit f93ac8b into master Dec 7, 2021
@arybczak arybczak deleted the better-join-kinds branch December 7, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading error message from JoinKinds

2 participants