Make chosen an indexed lens to see which value was traversed#335
Merged
Make chosen an indexed lens to see which value was traversed#335
Conversation
adamgundry
approved these changes
Aug 9, 2020
Member
adamgundry
left a comment
There was a problem hiding this comment.
This seems reasonable to me, if slightly backwards incompatible. Should we continue to export chosen from Optics.Lens as well, since one might reasonably want it for non-indexed lenses, or at least retain a reference to chosen in the Optics.Lens docs somehow?
Collaborator
Author
|
We could export On the other hand, breakage should be minimal (as usually you import umbrella modules such as |
Collaborator
Author
|
I added reference to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.