feat(ingress): add ingressClassName support#50
Merged
xet7 merged 1 commit intowekan:mainfrom Feb 19, 2026
Merged
Conversation
The deprecated annotation kubernetes.io/ingress.class has been removed from the default values. Users can now set ingress.className to specify the ingress class via the spec.ingressClassName field, which is the standard approach since networking.k8s.io/v1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ingress.classNamevalue to setspec.ingressClassNameon the Ingress resourcekubernetes.io/ingress.classannotation from default values commentThe
kubernetes.io/ingress.classannotation has been officially deprecated since Kubernetes 1.18 in favor ofspec.ingressClassName(part ofnetworking.k8s.io/v1). The chart currently has no way to setingressClassName, forcing users to rely on the deprecated annotation.This change is fully backward compatible — when
classNameis empty (the default), noingressClassNamefield is rendered. Existing users relying on the annotation are not affected.Test plan
helm templatewithclassName: "traefik"→ingressClassName: traefikrendered in spechelm templatewithclassName: "nginx"→ingressClassName: nginxrendered in spechelm templatewithclassName: ""(default) → noingressClassNamefield (backward compatible)