Geshi path can be configurable by setting $config->setGeshiPath(). Fixes #199#202
Closed
danielmarschall wants to merge 6 commits intowebsvnphp:masterfrom
Closed
Geshi path can be configurable by setting $config->setGeshiPath(). Fixes #199#202danielmarschall wants to merge 6 commits intowebsvnphp:masterfrom
danielmarschall wants to merge 6 commits intowebsvnphp:masterfrom
Conversation
Contributor
Author
|
Can you change the commit message? "$config" is missing there. |
Contributor
Author
|
Is this the correct use? |
Member
Yes, this is my understanding. Please give it a try. |
Contributor
Author
|
Ok. I have tested my current PR, and it works for me |
michael-o
requested changes
Nov 8, 2023
Contributor
Author
|
Thank you. You are right. I fixed it. |
michael-o
approved these changes
Nov 10, 2023
Member
michael-o
left a comment
There was a problem hiding this comment.
This looks logically sound to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #199