Skip to content

Geshi path can be configurable by setting $config->setGeshiPath(). Fixes #199#202

Closed
danielmarschall wants to merge 6 commits intowebsvnphp:masterfrom
danielmarschall:patch-2
Closed

Geshi path can be configurable by setting $config->setGeshiPath(). Fixes #199#202
danielmarschall wants to merge 6 commits intowebsvnphp:masterfrom
danielmarschall:patch-2

Conversation

@danielmarschall
Copy link
Copy Markdown
Contributor

Fixed #199

@danielmarschall
Copy link
Copy Markdown
Contributor Author

Can you change the commit message? "$config" is missing there.

Copy link
Copy Markdown
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use _setPath()?

@danielmarschall
Copy link
Copy Markdown
Contributor Author

danielmarschall commented Nov 7, 2023

Is this the correct use?

    var $geshiScript = 'geshi.php';

    function setGeshiPath($path) {
            $this->_setPath($this->geshiScript, $path, 'geshi.php');
    }

    function getGeshiScript() {
            return $this->geshiScript;
    }

@michael-o
Copy link
Copy Markdown
Member

Is this the correct use?

    var $geshiScript = 'geshi.php';

    function setGeshiPath($path) {
            $this->_setPath($this->geshiScript, $path, 'geshi.php');
    }

    function getGeshiScript() {
            return $this->geshiScript;
    }

Yes, this is my understanding. Please give it a try.

@danielmarschall
Copy link
Copy Markdown
Contributor Author

Ok. I have tested my current PR, and it works for me

@danielmarschall
Copy link
Copy Markdown
Contributor Author

Thank you. You are right. I fixed it.

Copy link
Copy Markdown
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks logically sound to me.

@michael-o michael-o closed this in fb53171 Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

require_once(geshi.php) in svnlook.php

2 participants