Make the root-phrase of the breadcrumb path configurable.#152
Merged
ams-tschoening merged 2 commits intomasterfrom Sep 12, 2021
Merged
Make the root-phrase of the breadcrumb path configurable.#152ams-tschoening merged 2 commits intomasterfrom
ams-tschoening merged 2 commits intomasterfrom
Conversation
The approach is to 1. get rid of the hard-coded string and make it a language property instead, so one can have phrases like "(root)" in English, "(wurzel)" in German or some arbitrary other string easily. Second, a new config is introduced to let WebSVN calculate the name of that root-phrase based on the name of the current repo automatically. that might make sense for a lot of people and is what's actually requested in the linked issue by @didiez. Third, the breadcrumb path rendered into templates has been splitted into root and non-root, so that templates can decide to use an arbitrary different root or none at all. Before, templates only received the whole rendered breadcrumb, which isn't pretty flexible. Things can easily be reverted with mass-replace anyway. Fixes #150.
k10blogger
approved these changes
Sep 7, 2021
michael-o
approved these changes
Sep 8, 2021
Contributor
Author
|
Agreed, couldn't find something better as well. Some former ideas:
|
Member
|
|
… for "ignoreAcceptedLanguages".
Contributor
Author
|
Yeah, not that much shorter... Additionally, I prefer my scheme of Anyway, doesn't seem that important right now and can be changed as necessary in future. What I still did was following the SET+GET naming scheme used for other booleans, looks more consistent now vs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The approach is to 1. get rid of the hard-coded string and make it a language property instead, so one can have phrases like "(root)" in English, "(wurzel)" in German or some arbitrary other string easily.
Second, a new config is introduced to let WebSVN calculate the name of that root-phrase based on the name of the current repo automatically. that might make sense for a lot of people and is what's actually requested in the linked issue by @didiez.
Third, the breadcrumb path rendered into templates has been splitted into root and non-root, so that templates can decide to use an arbitrary different root or none at all. Before, templates only received the whole rendered breadcrumb, which isn't pretty flexible. Things can easily be reverted with mass-replace anyway.
Fixes #150.