Show files in subdirs with parents with restricted access.#151
Merged
ams-tschoening merged 4 commits intomasterfrom Sep 12, 2021
Merged
Show files in subdirs with parents with restricted access.#151ams-tschoening merged 4 commits intomasterfrom
ams-tschoening merged 4 commits intomasterfrom
Conversation
Calling "showDirFiles" with a level of "0" always leads to possible failed access checks when "/", "/tags" etc. are NOT visible to the current user, while "/tags/DIR1" might be. This is because of early aborts when checking access starting from the root of the repo. Fixes #146.
62864ac to
099cb46
Compare
michael-o
reviewed
Sep 7, 2021
k10blogger
approved these changes
Sep 7, 2021
Member
k10blogger
left a comment
There was a problem hiding this comment.
Lets go ahead with $level = $limit change. if someone else find an issue with this maybe will come to know what could be wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling "showDirFiles" with a level of "0" always leads to possible failed access checks when "/", "/tags" etc. are NOT visible to the current user, while "/tags/DIR1" might be. This is because of early aborts when checking access starting from the root of the repo.
Fixes #146.