Skip to content

Vimeo#1702

Merged
kof merged 46 commits intomainfrom
1688-video-components
Jun 8, 2023
Merged

Vimeo#1702
kof merged 46 commits intomainfrom
1688-video-components

Conversation

@kof
Copy link
Copy Markdown
Member

@kof kof commented Jun 2, 2023

Ref #1688

Description

Vimeo Component

Steps for reproduction

  1. Add vimeo
  2. play with props

Code Review

  • hi @TrySound , I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@kof kof linked an issue Jun 2, 2023 that may be closed by this pull request
17 tasks
@vercel
Copy link
Copy Markdown

vercel bot commented Jun 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Jun 7, 2023 11:14pm

Copy link
Copy Markdown
Contributor

@taylornowotny taylornowotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works well!

@kof kof merged commit b71dc75 into main Jun 8, 2023
@kof kof deleted the 1688-video-components branch June 8, 2023 00:08
} from "react";

const defaultTag = "div";
export const defaultTag = "div";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessary anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vimeo Component

4 participants