Add explicit tag fixes for source issues #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following words have issues with either missing or extra p-tags that cause severe issues processing: - "Lese majesty" - "Condorcet's method" - "Roller" - "Stooge" This adds explicit fixes for these cases so that processing can continue as normal. I've reported this tag issues upstream and these replacements could be removed if/when the fixes occur. Closes websterParser#56 and closes websterParser#73.
Contributor
Author
|
@jeffbyrnes Any suggestions on how to handle the build failure here with the submodule? |
Collaborator
|
I noted elsewhere that I think GitHub is being blocked from that Git server. @ponychicken is gonna hook me up with some broader access when they return from vacation soon, and I’ll sort it out at that point. |
Contributor
Author
|
Looks like the submodule reference needed updating (again?). Build is green now! |
This was referenced Aug 10, 2022
|
I installed this and tested all the words that were previously reported as problems and it looks good. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following words have issues with either missing or extra p-tags that cause
severe issues processing:
This adds explicit fixes for these cases so that processing can continue
as normal. I've reported this tag issues upstream and these replacements
could be removed if/when the fixes occur.
Closes #56 and closes #73.