Security: Use crypto.randomBytes, not Math.random#994
Merged
lpinca merged 2 commits intowebsockets:v1.xfrom Feb 8, 2017
Merged
Security: Use crypto.randomBytes, not Math.random#994lpinca merged 2 commits intowebsockets:v1.xfrom
lpinca merged 2 commits intowebsockets:v1.xfrom
Conversation
This is a backport of https://github.com/websockets/ws/pull/832/files to v1.1.1, so that projects that still need to support Node < 4 can get the security patch.
lpinca
reviewed
Feb 8, 2017
lib/Sender.js
Outdated
| ~~(Math.random() * 255), | ||
| ~~(Math.random() * 255) | ||
| ]); | ||
| return require('crypto').randomBytes(4); |
Member
There was a problem hiding this comment.
Only a tiny nit: would you mind moving the require at the top of the file along with the others?
Member
|
Thanks! |
This was referenced Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of https://github.com/websockets/ws/pull/832/files to v1.x, so that projects that still need to support Node < 4 can get the security patch.