Fix stack overflow crash#810
Merged
JacksonTian merged 2 commits intowebsockets:masterfrom Sep 22, 2016
Merged
Conversation
Contributor
|
Could you provide a test case? |
Contributor
Author
|
@JacksonTian done. I found the issue happens when you send too many messages while one is still processing. |
Member
|
LGTM. |
|
@JacksonTian any way you can publish a patch release with this fix? I'd very much appreciate it. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a message has many messageHandlers it can trigger a stack overflow as it recursively calls flush on each one. This ensures that the stack is cleared before each recursive flush is called.
Fixes #809