-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Comparing changes
Open a pull request
base repository: websockets/ws
base: 7.5.3
head repository: websockets/ws
compare: 8.0.0
- 18 commits
- 31 files changed
- 1 contributor
Commits on Jul 14, 2021
-
[major] Validate subprotocol names
Make the `WebSocket` constructor throw a `SyntaxError` if any of the subprotocol names are invalid or duplicated.
2Configuration menu - View commit details
-
Copy full SHA for 0aecf0c - Browse repository at this point
Copy the full SHA 0aecf0cView commit details -
[major] Validate the Sec-WebSocket-Protocol header
Abort the handshake if the `Sec-WebSocket-Protocol` header is invalid.
Configuration menu - View commit details
-
Copy full SHA for 1877dde - Browse repository at this point
Copy the full SHA 1877ddeView commit details -
[major] Make the Sec-WebSocket-Extensions header parser stricter
Make the parser throw an error if the header field value is empty or if it begins or ends with a white space.
Configuration menu - View commit details
-
Copy full SHA for e814110 - Browse repository at this point
Copy the full SHA e814110View commit details -
Configuration menu - View commit details
-
Copy full SHA for 552b506 - Browse repository at this point
Copy the full SHA 552b506View commit details -
[major] Throw an error if the connection URL is invalid
Make the `WebSocket` constructor throw a `SyntaxError` if the URL contains a fragment identifier or if the URL's protocol is not one of `'ws:'`, `'wss:'`, or `'ws+unix:'`.
1Configuration menu - View commit details
-
Copy full SHA for ebea038 - Browse repository at this point
Copy the full SHA ebea038View commit details -
Configuration menu - View commit details
-
Copy full SHA for e173423 - Browse repository at this point
Copy the full SHA e173423View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78adf5f - Browse repository at this point
Copy the full SHA 78adf5fView commit details -
[major] Do not close existing connections
When `WebSocketServer.prototype.close()` is called, stop accepting new connections but do not close the existing ones. If the HTTP/S server was created internally, then close it and emit the `'close'` event when it closes. Otherwise, if client tracking is enabled, then emit the `'close'` event when the number of connections goes down to zero. Otherwise, emit it in the next tick. Refs: #1902
Configuration menu - View commit details
-
Copy full SHA for df7de57 - Browse repository at this point
Copy the full SHA df7de57View commit details -
[major] Call the callback with an error if the server is closed
Match the behavior of Node.js core `net.Server` and call the callback of `WebSocketServer.prototype.close()` with an error if the server is already closed.
Configuration menu - View commit details
-
Copy full SHA for abde9cf - Browse repository at this point
Copy the full SHA abde9cfView commit details
Commits on Jul 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 64b3c71 - Browse repository at this point
Copy the full SHA 64b3c71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77a675c - Browse repository at this point
Copy the full SHA 77a675cView commit details
Commits on Jul 29, 2021
-
[major] Make
WebSocket#addEventListener()ignore non standard eventsMake `WebSocket.prototype.addEventListener()` a noop if the `type` argument is not one of `'close'`, `'error'`, `'message'`, or `'open'`.
Configuration menu - View commit details
-
Copy full SHA for 9558ed1 - Browse repository at this point
Copy the full SHA 9558ed1View commit details -
[major] Ignore listeners not added with
WebSocket#addEventListener()Make `WebSocket.prototype.removeEventListener()` only remove listeners added with `WebSocket.prototype.addEventListener()` and only one at time.
Configuration menu - View commit details
-
Copy full SHA for ea95d9c - Browse repository at this point
Copy the full SHA ea95d9cView commit details -
[fix] Make listeners added via event handler properties independent
Prevent the `onclose`, `onerror`, `onmessage`, and `onopen` getters and setters from returning or removing event listeners added with `WebSocket.prototype.addEventListener()`. Also prevent `WebSocket.prototype.removeEventListener()` from removing event listeners added with the `onclose`, `onerror`, `onmessage`, and `onopen` setters. Refs: #1818
Configuration menu - View commit details
-
Copy full SHA for 8c61563 - Browse repository at this point
Copy the full SHA 8c61563View commit details -
[fix] Return
nullif the event handler is not setMake the `onclose`, `onerror`, `onmessage`, and `onopen` getters return `null` instead of `undefined` if the event handler is not set.
Configuration menu - View commit details
-
Copy full SHA for 6756cf5 - Browse repository at this point
Copy the full SHA 6756cf5View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd7febb - Browse repository at this point
Copy the full SHA bd7febbView commit details -
[major] Overhaul event classes
- Remove non-standard `OpenEvent` class. - Make properties read-only. - Update constructor signatures to match the ones defined by the HTML standard.
Configuration menu - View commit details
-
Copy full SHA for 21e6500 - Browse repository at this point
Copy the full SHA 21e6500View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc40248 - Browse repository at this point
Copy the full SHA fc40248View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 7.5.3...8.0.0