Load system default certificates if none are given#415
Merged
Conversation
This changes behavior. When creating a TLS connection, not specifying cacert/capath and while on a Python version without load_default_certs, creating the socket will not fail as before, but verifying the connection will fail instead.
Contributor
Author
|
Removed the bundled cacert.pem to make this work as intended when the Python version supports loading default certs. It will not work without explicitly passing a cert bundle on other versions. |
Contributor
Author
|
It looks like support for system certs was added in #88 already, but it looks like that broke. Just removing Regardless, relying on the |
Contributor
Author
|
FYI this should work on Python 2.7.9+,released 2014-12-10, in which |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When not providing a CA file or path, load the system default certificate stores instead. This may fail (according to
ssl.create_default_context)Fixes #413. Compatibility with older Python versions untested. Should work on 3.4+, but I couldn't find info on Python 2.