Fix missing RTC_OBJC_TYPE macro on SckHelper#227
Merged
cloudwebrtc merged 1 commit intowebrtc-sdk:m137_releasefrom Mar 12, 2026
Merged
Fix missing RTC_OBJC_TYPE macro on SckHelper#227cloudwebrtc merged 1 commit intowebrtc-sdk:m137_releasefrom
cloudwebrtc merged 1 commit intowebrtc-sdk:m137_releasefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SckHelperinmodules/desktop_capture/mac/screen_capturer_sck.mmis not wrapped withRTC_OBJC_TYPE(). When building withrtc_objc_prefix, this class is not renamed, causing ObjC runtime collisions if another copy of WebRTC is linked into the same binary.For context, there were previous omissions covered by these PRs:
RTC_OBJC_TYPEmacros #100RTC_OBJC_TYPEmacro #171RTC_OBJC_TYPEmacro #174