Fix background job email failures #3045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
247d3ce to
365e1b7
Compare
ikreymer
reviewed
Dec 3, 2025
| {"$set": {"success": success, "finished": finished}}, | ||
| ) | ||
|
|
||
| if not success: |
Member
There was a problem hiding this comment.
Nice, yeah, good to do it in this order, first update db, then send email.
…sent for testing" This reverts commit 4ff016d.
ikreymer
approved these changes
Dec 3, 2025
Member
ikreymer
left a comment
There was a problem hiding this comment.
Added a minor logging fix, tested on dev and emails sending as expected now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3044
asyncio.create_taskto send background job failure emails (tracking tasks in set in ops class to avoid garbage collection)handle_replica_job_finishedtohandle_replica_job_succeededto better reflect intentNote: The latest commit should be dropped before merging but allows for easy testing of a failed replica job that will trigger an email.
Further job-related improvements will be handled in a future release. Some work toward that has been removed from this PR and saved as main...job-failure-improvements-extended