fix: Fix profile tag count changing after delete #3026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hm, that worked (deleting a non-tagged profile and count of tagged remained the same), but then I deleted one of the two profiles with the tag, and the count did not update (was still 2). Is that a separate issue? |
Member
Author
This is a separate issue that affects other lists. Opened issue: #3035 |
ikreymer
approved these changes
Dec 1, 2025
Member
ikreymer
left a comment
There was a problem hiding this comment.
Looks good! Update on actual delete is a separate issue now tracked separately, so this is good to go.
d014aae
into
frontend-browser-profile-ui-enhancements
29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes incorrect browser profile tag remainder calculation after a profile is deleted
Manual testing