feat: Standardize browser profile display and proxy setting #3004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
frontend-browser-profile-ui-enhancements--load-from-workflow
to
frontend-browser-profile-ui-enhancements
November 20, 2025 05:11
b7d4ae1 to
786433a
Compare
Member
|
Looks good so far! Tested it with:
|
22a33b4 to
03400ce
Compare
4441d74 to
9044b27
Compare
Member
|
Looks great! Only noticed one thing with the proxy when profile is set: Maybe it should just set "set by Browser Profile" or "from Browser Profile" or "controlled by browser profile" and not have the tooltip, or just have info popover and have the message there? |
Member
Author
Changed to "Set by profile" |
ikreymer
approved these changes
Nov 26, 2025
6143dfe to
2e390d6
Compare
1511f9b
into
frontend-browser-profile-ui-enhancements
28 of 29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2982
Fixes #3005
Depends on #3009
Changes
Screenshots