Skip to content

Add backend tags support for profiles #2974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuaYoo merged 6 commits into from
Nov 13, 2025
Merged

Add backend tags support for profiles #2974

SuaYoo merged 6 commits into from
Nov 13, 2025

Conversation

@tw4l
Copy link
Member

@tw4l tw4l commented Nov 10, 2025

Fixes #2961

  • Add support for tags in profile create and update endpoints
  • Add profile tagCounts endpoint to aid in list filters/search
  • Add tests

@tw4l tw4l requested review from SuaYoo and ikreymer November 10, 2025 18:54
@tw4l tw4l changed the title Add tags to profiles Add backend tags support for profiles Nov 10, 2025
This was referenced Nov 11, 2025
Merged
Merged
@tw4l
Copy link
Member Author

tw4l commented Nov 11, 2025

Moving back to draft while I add crawl filtering to list GET endpoint

@tw4l tw4l marked this pull request as draft November 11, 2025 18:43
@tw4l tw4l force-pushed the issue-2961-browser-profile-tags branch 3 times, most recently from 6199be9 to 8baeb74 Compare November 11, 2025 19:42
@tw4l tw4l marked this pull request as ready for review November 11, 2025 20:42
tw4l added 3 commits November 11, 2025 15:47
@tw4l
Add tags to profiles
71b5080 
- Add support for tags in profile create and update endpoints
- Add profile tagCounts endpoint to aid in list filters/search
- Add tests
@tw4l
Add tag and tagMatch support to profile list endpoint
d570c6e
@tw4l
Use repeated tag query for lists in tests
be40df0
@tw4l tw4l force-pushed the issue-2961-browser-profile-tags branch from c555fa9 to be40df0 Compare November 11, 2025 20:47
@tw4l
Copy link
Member Author

tw4l commented Nov 11, 2025 •
edited
Loading

@SuaYoo Tag filtering now added. I had to rebase on the changes in main so just going to make sure all looks okay in the tests (edit: all looks good! backend and nightly tests all passed)

@SuaYoo
Copy link
Member

SuaYoo commented Nov 12, 2025

Tested with #2976 and filters are working; minor note, it looks like the tag filter name is slightly inconsistent between endpoints:

  • all-crawls: tags
  • crawlconfigs: tag
  • profiles: tag

@ikreymer
Copy link
Member

ikreymer commented Nov 13, 2025 •
edited
Loading

Tested with #2976 and filters are working; minor note, it looks like the tag filter name is slightly inconsistent between endpoints:

  • all-crawls: tags
  • crawlconfigs: tag
  • profiles: tag

Yeah, this is a good point - I wonder if we should make it one or the other? I think we use tags more internally, but for some reason the query arg ended up being tag.

We could:

  • Add to tags but keep tag on crawlconfigs, mark it as deprecated.
  • Switch the one on profiles to also be tags

@SuaYoo
Copy link
Member

SuaYoo commented Nov 13, 2025

We could:

* Add to `tags` but keep `tag` on crawlconfigs, mark it as deprecated.

* Switch the one on profiles to also be `tags`

Yes let's have browser profiles be whichever we want the query to be moving forward.

SuaYoo
SuaYoo approved these changes Nov 13, 2025
View reviewed changes
Copy link
Member

@SuaYoo SuaYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested new changes, looks good

@SuaYoo SuaYoo merged commit bca5ce7 into main Nov 13, 2025
24 checks passed
@SuaYoo SuaYoo deleted the issue-2961-browser-profile-tags branch November 13, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikreymer ikreymer ikreymer approved these changes

@SuaYoo SuaYoo SuaYoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Task]: Add browser profile tags

4 participants

@tw4l @SuaYoo @ikreymer