Skip to content

fix: Use org crawling defaults for new browser profile #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuaYoo merged 6 commits into from
Oct 28, 2025
Merged

fix: Use org crawling defaults for new browser profile #2937

SuaYoo merged 6 commits into from
Oct 28, 2025

Conversation

@SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Oct 28, 2025

Resolves #2281

Changes

  • Uses org crawling defaults when creating new browser profile
  • Refactors "default" image to enum

Manual testing

  1. Log in as crawler to org with proxies
  2. Go to "Settings" > "Crawling Defaults"
  3. Set default proxy and default crawler channel
  4. Go to "Browser Profiles"
  5. Choose "New Browser Profile". Verify org defaults are selected

@SuaYoo SuaYoo requested review from ikreymer and tw4l October 28, 2025 18:25
tw4l
tw4l approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@SuaYoo SuaYoo merged commit 4c48d8a into main Oct 28, 2025
29 checks passed
@SuaYoo SuaYoo deleted the frontend-browser-profile-org-defaults branch October 28, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tw4l tw4l tw4l approved these changes

@ikreymer ikreymer Awaiting requested review from ikreymer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Use org defaults when creating new browser profile

3 participants

@SuaYoo @tw4l