Skip to content

Conversation

@tw4l
Copy link
Member

@tw4l tw4l commented Oct 9, 2025

Fixes #2891

  • Fix profile filenames in database to be full path in bucket (including org id prefix) for new profiles
  • Add migration to fix profile filenames that don't already have org id prefix, and for each found, delete existing replicas from database (files were never pushed to s3) and then run background jobs to replicate
  • Add --error-on-no-transfer flag to rclone replication job to fail with non-0 exit code if source file isn't found or another issue prevents copy from being successful

@tw4l tw4l force-pushed the issue-2891-profile-filename-fix branch from 38deff5 to 5f53596 Compare October 13, 2025 19:44
@tw4l tw4l force-pushed the issue-2891-profile-filename-fix branch from 5f53596 to a091cfc Compare October 13, 2025 19:59
@tw4l tw4l changed the title WIP: Fix profile filenames in database Fix profile filenames in database Oct 13, 2025
@tw4l tw4l changed the title Fix profile filenames in database Fix profile filenames in database and re-replicate Oct 13, 2025
@tw4l tw4l marked this pull request as ready for review October 13, 2025 20:41
@tw4l tw4l requested a review from ikreymer October 13, 2025 20:41
@ikreymer
Copy link
Member

Tested on dev, added a small fix of changing replicas to empty array instead of null, otherwise working well!

@ikreymer ikreymer added this to the 1.19.4 Release milestone Oct 15, 2025
@ikreymer ikreymer merged commit 58b0edf into main Oct 16, 2025
25 of 26 checks passed
@ikreymer ikreymer deleted the issue-2891-profile-filename-fix branch October 16, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Browser profile filepaths are incorrect in database

3 participants