Skip to content

Propagate field notes #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cclauss merged 4 commits into from
Apr 30, 2024
Merged

Propagate field notes #790

cclauss merged 4 commits into from
Apr 30, 2024

Conversation

@gjdv
Copy link
Contributor

@gjdv gjdv commented Apr 30, 2024 •
edited by cclauss
Loading

Fixes #739

@gjdv gjdv mentioned this pull request Apr 30, 2024
Closed
@cclauss
Copy link
Contributor

cclauss commented Apr 30, 2024

OK... Please give me a few minutes to exercise this. I will

  1. black format the code to make the linter pass
  2. disable the changes to web/form.py and make sure the tests fail.
  3. reenable the changes to web/form.py and make sure the tests pass.
  4. Squash and merge...

cclauss
cclauss approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution.

@cclauss cclauss merged commit 952d1fd into webpy:master Apr 30, 2024
@gjdv gjdv deleted the propagate_field_notes branch April 30, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Field validators don't return their msg when they fail

2 participants

@gjdv @cclauss