feat: detect duplicated package.json dependencies#1611
Conversation
commit: |
|
I don't think the "argos" CI failure is related to my pull request. |
lishaduck
left a comment
There was a problem hiding this comment.
This looks fine, but just the usual friendly reminder that it's completely valid (encouraged even!) to have a duplicate between peerDependencies and one of dependencies/devDependencies. 😄
(Happened to notice this PR in passing, excited to see this one land! ❤️)
Yup, true. Just to clarify, this PR explicitly checks for dupes between "dependencies" and "devDependencies". It does not look at "peerDependencies" at all. (Or optionalDependencies/bundledDependencies/bundleDependencies.) |
|
Thanks James, the CI "failure" is exactly caused by your changes ;) ❤️ |
|
Oh whoops. I guess it wasn't a blocker though? |
|
🚀 This pull request is included in v5.88.0. See Release 5.88.0 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
|
🚀 This pull request is included in v6.0.0-2. See Release 6.0.0-2 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
Fixes #1610
Claude helped me write this PR.