feat: add a noRuntime option#831
Merged
alexander-akait merged 1 commit intowebpack:masterfrom Sep 11, 2021
Merged
Conversation
|
|
feat: add a noRuntime option
alexander-akait
approved these changes
Sep 11, 2021
Codecov Report
@@ Coverage Diff @@
## master #831 +/- ##
=======================================
Coverage 92.80% 92.81%
=======================================
Files 6 6
Lines 723 724 +1
Branches 176 177 +1
=======================================
+ Hits 671 672 +1
Misses 49 49
Partials 3 3
Continue to review full report at Codecov.
|
Member
|
@cbazureau #832, just rename to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
As seen here webpack/css-loader#1362 and here #711 i've added a
noRuntimeoption to avoid the runtime generation. Assets are still extracted and can be used for a custom loading methods.Another PR (#807) tried to do something similar but does others things and will need a rebase. In comparaison i'm using a more minimal approach and add unit tests that shown that :
Breaking Changes
None
Additional Info
None