feat: pass immutable info on files#383
feat: pass immutable info on files#383alexander-akait merged 1 commit intowebpack-contrib:masterfrom bschlenk:master
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 29 30 +1
Branches 12 12
=========================================
+ Hits 29 30 +1
Continue to review full report at Codecov.
|
|
|
||
| const context = options.context || this.rootContext; | ||
| const name = options.name || '[contenthash].[ext]'; | ||
| const immutable = /\[([^:\]]+:)?(hash|contenthash)(:[^\]]+)?\]/gi.test(name); |
There was a problem hiding this comment.
Ideally this would be another function in https://github.com/webpack/loader-utils
There was a problem hiding this comment.
Yes, I will test it deeply in near future
|
not sure why ModuleConcatenationPlugin test is failing. Source doesn't use the |
|
I think we should improve test, webpack@5 implements better tree so count of modules can be reduced |
|
I will merge and fix tests after merge |
This PR contains a:
Motivation / Use-Case
Passes an
immutableflag through assetInfo which other plugins may use.#382
Breaking Changes
Additional Info