Skip to content

improve SourceMapSource nested mapping with identity mapping support#53

Merged
sokra merged 1 commit intomasterfrom
feature/nested-source-map-identify
Jul 31, 2019
Merged

improve SourceMapSource nested mapping with identity mapping support#53
sokra merged 1 commit intomasterfrom
feature/nested-source-map-identify

Conversation

@sokra
Copy link
Copy Markdown
Member

@sokra sokra commented Jul 31, 2019

together with a fix in terser-webpack-plugin this fixes #51 (tested with https://github.com/adaniliuk/webpack-sourcemap-testing)

fixes webpack/webpack#8302

image

@sokra sokra force-pushed the feature/nested-source-map-identify branch from 0726518 to c059741 Compare July 31, 2019 08:44
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 31, 2019

Codecov Report

Merging #53 into master will increase coverage by 4.76%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   78.25%   83.01%   +4.76%     
==========================================
  Files          11       12       +1     
  Lines         492      571      +79     
  Branches       76      100      +24     
==========================================
+ Hits          385      474      +89     
+ Misses        107       97      -10
Impacted Files Coverage Δ
lib/ReplaceSource.js 96.33% <ø> (-0.06%) ⬇️
lib/SourceMapSource.js 74.28% <100%> (+52.66%) ⬆️
lib/applySourceMap.js 100% <100%> (ø)
lib/PrefixSource.js 69.09% <100%> (-13.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bdea14...c059741. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 31, 2019

Codecov Report

Merging #53 into master will increase coverage by 4.78%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   78.25%   83.04%   +4.78%     
==========================================
  Files          11       12       +1     
  Lines         492      572      +80     
  Branches       76      100      +24     
==========================================
+ Hits          385      475      +90     
+ Misses        107       97      -10
Impacted Files Coverage Δ
lib/ReplaceSource.js 96.33% <ø> (-0.06%) ⬇️
lib/SourceMapSource.js 75% <100%> (+53.37%) ⬆️
lib/PrefixSource.js 69.09% <100%> (-13.41%) ⬇️
lib/applySourceMap.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bdea14...1030f64. Read the comment docs.

@sokra sokra force-pushed the feature/nested-source-map-identify branch from c059741 to 1030f64 Compare July 31, 2019 09:42
@sokra sokra merged commit cf09deb into master Jul 31, 2019
@sokra sokra deleted the feature/nested-source-map-identify branch July 31, 2019 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webpack is producing invalid sourcemaps?

1 participant