Skip to content

feat: remove caret in @types/ws package version#4894

Closed
JansenMoscol wants to merge 1 commit intowebpack:masterfrom
JansenMoscol:master
Closed

feat: remove caret in @types/ws package version#4894
JansenMoscol wants to merge 1 commit intowebpack:masterfrom
JansenMoscol:master

Conversation

@JansenMoscol
Copy link
Copy Markdown

@JansenMoscol JansenMoscol commented Jun 8, 2023

I have error with version 8.5.5

node_modules/@types/ws/index.d.ts(328,18): error TS2315: Type 'Server' is not generic.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Jun 8, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: JansenMoscol / name: Jansen Moscol (b4a8316)

@alexander-akait
Copy link
Copy Markdown
Member

Why?

@JansenMoscol
Copy link
Copy Markdown
Author

Because I have error with version 8.5.5

node_modules/@types/ws/index.d.ts(328,18): error TS2315: Type 'Server' is not generic.

@alexander-akait
Copy link
Copy Markdown
Member

alexander-akait commented Jun 8, 2023

Please fix your typescript code, it is transitive dependency

@JansenMoscol
Copy link
Copy Markdown
Author

It's not my code, the new version @types/ws 8.5.5 broke the library. You can try doing a clean install.

@alexander-akait
Copy link
Copy Markdown
Member

@JansenMoscol In this case please open an issue in @types/ws, i.e. in https://github.com/DefinitelyTyped/DefinitelyTyped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants