fix: delete additional#4796
Closed
cmw-big wants to merge 2 commits into
Closed
Conversation
|
|
alexander-akait
approved these changes
Mar 30, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4796 +/- ##
==========================================
- Coverage 91.83% 90.33% -1.51%
==========================================
Files 16 16
Lines 1665 1665
Branches 624 624
==========================================
- Hits 1529 1504 -25
- Misses 125 147 +22
- Partials 11 14 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Member
|
typescript has strange bugs with type generation, I send an another PR to fix it - #4797, anyway big thank you for this PR |
Member
|
@cmw-big Anyway, big thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Motivation / Use-Case
"When I was reading lib/Server.js, I noticed that the type name was duplicated between line 199 and line 189, so I thought about submitting a PR."
Breaking Changes
Additional Info