fix: allow more client options to be configured via resource url (#4156)#4157
Closed
jnu wants to merge 5 commits intowebpack:masterfrom
Closed
fix: allow more client options to be configured via resource url (#4156)#4157jnu wants to merge 5 commits intowebpack:masterfrom
jnu wants to merge 5 commits intowebpack:masterfrom
Conversation
|
|
Author
|
ok sure, I will update this afternoon. thanks!
…On Tue, Jan 11, 2022 at 9:20 AM Alexander Akait ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In client-src/index.js
<#4157 (comment)>
:
> @@ -58,6 +58,18 @@ if (parsedResourceQuery["live-reload"] === "true") {
log.info("Live Reloading enabled.");
}
+if (parsedResourceQuery.progress === "true") {
+ options.progress = true;
+
+ log.info("Progress reporting enabled.");
+}
+
+if (parsedResourceQuery.overlay === "true") {
+ options.overlay = true;
+
+ log.info("Error overlay enabled.");
+}
I think we can use JSON.stringify/JSON.parse to support more options
—
Reply to this email directly, view it on GitHub
<#4157 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIFGS3DDWUOTOQIK45M6TLUVRREVANCNFSM5LKWM5WA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
jnu
commented
Jan 12, 2022
Codecov Report
@@ Coverage Diff @@
## master #4157 +/- ##
==========================================
+ Coverage 92.27% 92.49% +0.21%
==========================================
Files 14 14
Lines 1541 1558 +17
Branches 590 598 +8
==========================================
+ Hits 1422 1441 +19
+ Misses 110 108 -2
Partials 9 9
Continue to review full report at Codecov.
|
snitin315
reviewed
Jan 13, 2022
snitin315
reviewed
Jan 18, 2022
Member
snitin315
left a comment
There was a problem hiding this comment.
I believe we also need to set these options automatically if provided in configuration, as we do for other client options like logging.
webpack-dev-server/lib/Server.js
Line 596 in e99c0bc
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes, added tests for parsing resource query options
Motivation / Use-Case
See #4156
Breaking Changes
No breaking changes.
Additional Info