Skip to content

feat: Interactive Plugin#3243

Closed
rishabh3112 wants to merge 12 commits intomasterfrom
feat/interactive
Closed

feat: Interactive Plugin#3243
rishabh3112 wants to merge 12 commits intomasterfrom
feat/interactive

Conversation

@rishabh3112
Copy link
Member

@rishabh3112 rishabh3112 commented May 14, 2022

Different from interactive at #586: This PR just adds support for interactive output mode.

What kind of change does this PR introduce?
Feature

Did you add tests for your changes?

If relevant, did you update the documentation?
Not applicable

Summary
There are two output modes for --watch and webpack serve, standard and interactive.
Standard is already supported. This PR aims to implement that.

Does this PR introduce a breaking change?
No

Other information
/cc @alexander-akait

@rishabh3112 rishabh3112 changed the title chore: Interactive Plugin feat: Interactive Plugin May 14, 2022
@codecov
Copy link

codecov bot commented May 14, 2022 •
edited
Loading

Codecov Report

Merging #3243 (e6835e3) into master (748ae9e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3243   +/-   ##
=======================================
  Coverage   92.08%   92.08%           
=======================================
  Files          23       23           
  Lines        1731     1731           
  Branches      519      519           
=======================================
  Hits         1594     1594           
  Misses        137      137
Impacted Files Coverage Δ
packages/webpack-cli/src/webpack-cli.ts 93.95% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5034913...e6835e3. Read the comment docs.

evenstensberg
evenstensberg reviewed May 14, 2022
View reviewed changes
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just empty code though....

@rishabh3112
Copy link
Member Author

rishabh3112 commented May 16, 2022

This is just empty code though....

Yeah, I know 😆 . See #1796 closing comment for more info.

@alexander-akait
Copy link
Member

alexander-akait commented May 16, 2022

Yes, let's finish it, although perhaps we should first do major release:

  • drop node v12
  • drop webpack-dev-server v3
  • update deps (there is possible without big changes)

@rishabh3112
Copy link
Member Author

rishabh3112 commented May 17, 2022

Yes, let's finish it, although perhaps we should first do major release:

  • drop node v12
  • drop webpack-dev-server v3
  • update deps (there is possible without big changes)

Okay, will do.
Should node version 10 be removed too?

@rishabh3112 rishabh3112 mentioned this pull request May 17, 2022
Merged
@alexander-akait
Copy link
Member

alexander-akait commented Apr 29, 2023

Sorry for losing your time, but let's close it due #586 (comment)

In the future, we should study better and deeper the issues of what we should develop or not, in order not to get into such situations, once again I deeply apologize

@alexander-akait alexander-akait deleted the feat/interactive branch April 29, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evenstensberg evenstensberg evenstensberg left review comments

Assignees

No one assigned

Labels

Feature PR: unreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rishabh3112 @alexander-akait @evenstensberg @webpack-bot