Conversation
Codecov Report
@@ Coverage Diff @@
## master #2879 +/- ##
==========================================
- Coverage 94.95% 93.01% -1.94%
==========================================
Files 31 30 -1
Lines 1704 1647 -57
Branches 484 448 -36
==========================================
- Hits 1618 1532 -86
- Misses 86 115 +29
Continue to review full report at Codecov.
|
| }, | ||
| "engines": { | ||
| "node": ">=10.13.0" | ||
| "node": ">=12.13.0" |
There was a problem hiding this comment.
This is the min for ESM support. Same needed for other subpackages
| "node": ">=12.13.0" | |
| "node": ">=12.22.0" |
| @@ -1 +0,0 @@ | |||
| _ | |||
There was a problem hiding this comment.
This is needed because husky adds it's install time scripts in this folder that aren't supposed to be tracked
| "jest-watch-typeahead": "^0.6.1", | ||
| "lerna": "^4.0.0", | ||
| "lint-staged": "^10.5.0", | ||
| "lint-staged": "^11.1.1", |
There was a problem hiding this comment.
Minor, this is up to 12 now
What kind of change does this PR introduce?
refactoring + bugfix + features + other
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
It is the next branch
Does this PR introduce a breaking change?
Yes, list of breaking changes will be here in future
Other information
TODO:
drop node v10drop webpack v4 + aliases forwatch(i.e.w),devtool. i.e.d,targetist,output-pathisowere removedprefetch--entryrequire--entry-resetbefore (need add test(s))--targetrequire--target-resetbefore (need add test(s))buildtests - avoid usingscripts/prepareSuite.jsand put all deps in toppackage.json+ rename testsnode-envshould be renamed?getBuiltInOptionsand remove extramap/reduce/etc and avoid usingbuiltInOptionsCacheprocess.exit()webpack versionin favorwebpack info