Conversation
Codecov Report
@@ Coverage Diff @@
## master #2868 +/- ##
==========================================
+ Coverage 94.95% 94.99% +0.04%
==========================================
Files 31 31
Lines 1704 1719 +15
Branches 484 488 +4
==========================================
+ Hits 1618 1633 +15
Misses 86 86
Continue to review full report at Codecov.
|
alexander-akait
left a comment
There was a problem hiding this comment.
Let's add tests with --merge too
|
I am also implementing |
|
Yep, it is great idea |
506f46b to
4f5de57
Compare
|
|
||
| await this.resolveConfig(newOptions); | ||
| } | ||
| }); |
There was a problem hiding this comment.
We do not use webpack-merge logic here? it is working good
There was a problem hiding this comment.
We will also need to load the extended configurations, here we have only paths for extended configurations and not their options.
Or am I missing something here?
There was a problem hiding this comment.
Ideally --extends means --config=webpack.config.js --config=webpack.other.config.js --merge, so I think we already have logic for this, for the next major release we will change logic for multiple --config https://github.com/webpack/webpack-cli/blob/master/packages/webpack-cli/lib/webpack-cli.js#L1619, I think we will throw an error on two and more config options without --merge, but we can reuse this logic for --extends, --extends like syntax sugar, also do not forget --extends in CLI should override extends on webpack.config.js (I think eslint works the same, but need check)
4993cab to
8e352fa
Compare
|
Fixed #3738 |
What kind of change does this PR introduce?
FEATURE
Did you add tests for your changes?
yes, more tests WIP
If relevant, did you update the documentation?
WIP
Summary
Fixes #2748
Does this PR introduce a breaking change?
No
Other information
WIP in covering more edge cases with multiple nested configs and multi compiler mode.