Skip to content

docs(templates): Branding guide violation fix#1226

Merged
ematipico merged 3 commits intowebpack:masterfrom
wizardofhogwarts:patch-1
Feb 16, 2020
Merged

docs(templates): Branding guide violation fix#1226
ematipico merged 3 commits intowebpack:masterfrom
wizardofhogwarts:patch-1

Conversation

@wizardofhogwarts
Copy link
Copy Markdown
Contributor

@wizardofhogwarts wizardofhogwarts commented Feb 16, 2020

No description provided.

rishabh3112
rishabh3112 requested changes Feb 16, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wizardofhogwarts!
Please change title such that it suggests branding guide violation.
Also left a suggestion.

@wizardofhogwarts
Copy link
Copy Markdown
Contributor Author

wizardofhogwarts commented Feb 16, 2020

Hi @wizardofhogwarts!
Please change title such that it suggests branding guide violation.
Also left a suggestion.

@rishabh3112 Can you please suggest a title

@webpack-bot
Copy link
Copy Markdown

webpack-bot commented Feb 16, 2020

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@webpack-bot
Copy link
Copy Markdown

webpack-bot commented Feb 16, 2020

@wizardofhogwarts Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@rishabh3112 Please review the new changes.

anshumanv
anshumanv reviewed Feb 16, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commitlint is failing, can you amend your commit or commit using npm run commit?

@wizardofhogwarts wizardofhogwarts changed the title docs(templates): Grammatical fixes docs(templates): Branding guide violation fix Feb 16, 2020
@wizardofhogwarts
Copy link
Copy Markdown
Contributor Author

wizardofhogwarts commented Feb 16, 2020

Hi @wizardofhogwarts!
Please change title such that it suggests branding guide violation.
Also left a suggestion.

@rishabh3112 Can you please suggest a title

@rishabh3112 I have changed the title

@wizardofhogwarts @rishabh3112
chore: remove the from title
6d45310 
Co-Authored-By: Rishabh Chawla <rishabh31121999@gmail.com>
@webpack webpack deleted a comment Feb 16, 2020
@webpack webpack deleted a comment Feb 16, 2020
@ematipico ematipico merged commit ab910df into webpack:master Feb 16, 2020
@wizardofhogwarts wizardofhogwarts deleted the patch-1 branch March 22, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rishabh3112 rishabh3112 rishabh3112 approved these changes

@anshumanv anshumanv anshumanv approved these changes

@jamesgeorge007 jamesgeorge007 jamesgeorge007 approved these changes

+1 more reviewer

@ematipico ematipico ematipico approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: CI-ok PR: reviewed-approved PR: small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wizardofhogwarts @webpack-bot @ematipico @rishabh3112 @anshumanv @jamesgeorge007