fix: support both webpack versions#1065
Merged
evenstensberg merged 5 commits intomasterfrom Sep 5, 2019
Merged
Conversation
sokra
approved these changes
Aug 26, 2019
Member
sokra
left a comment
There was a problem hiding this comment.
Looks good to me, haven't tried to run it
ematipico
reviewed
Aug 27, 2019
Contributor
ematipico
left a comment
There was a problem hiding this comment.
Code wise looks good. I would move it into a separate a function so we can test it
bin/utils/convert-argv.js
Outdated
| const error = new WebpackOptionsValidationError(webpackConfigurationValidationErrors); | ||
| console.error(error.message, `\nReceived: ${typeof options} : ${JSON.stringify(options, null, 2)}`); | ||
| process.exit(-1); // eslint-disable-line | ||
| let error; |
Contributor
There was a problem hiding this comment.
Could you make a function out of it and export it? So we can test it and make sure 100% that it works.
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
16 tasks
ematipico
suggested changes
Sep 4, 2019
Contributor
ematipico
left a comment
There was a problem hiding this comment.
We should add the test now
|
@evenstensberg Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
Member
Author
|
Thanks for reviewing @ematipico . Singing this of and releasing 💙 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
#1023
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
N/A
Summary
Tries to resolve validation for both versions.
Does this PR introduce a breaking change?
no
Other information
@sokra could you verify? Tested locally, removed the
if/elsebut you might be aware of anymore pitfalls.