Conversation
3032caa to
4523798
Compare
valscion
left a comment
There was a problem hiding this comment.
Nice 👍. Can you add more changelog entries as well?
| .compact() | ||
| .flatten() | ||
| .uniqBy('id') | ||
| // Filtering out Webpack's runtime modules as they don't have ids and can't be parsed (introduced in Webpack 5) |
There was a problem hiding this comment.
Please keep these documentation comments as they give reasoning why certain logic exists :)
There was a problem hiding this comment.
Ah! I keep forgetting about this!
|
This PR and #505 have been released in v4.9.1 now |
|
the usage of those individual packages is discouraged: https://lodash.com/per-method-packages Also, as soon as another package also depends on lodash, this change actually increases the size of node_modules as lodash was deduplicated before. |
For most of my projects, the only copy of Since lodash is essentially dead (hasn't been maintained for years), IMHO instead of reverting back to lodash, replacing all |
|
Well, lodash is indeed kinda dead since 3 years. But the per-method packages have last been released 7 years ago. So they are still missing 4 years of work in the lodash package. |
The PR follows #505. The PR reduces
node_modulessize afternpm i webpack-bundle-analyzerwith 2 changes:chalkwithpicocolorslodashwith individuallodash.*packages.Comparison
Running
npm i --omit=dev --omit=optionalagainstwebpack-contrib/webpack-bundle-analyzer:master:Running
npm i --omit=dev --omit=optionalagainstsukkaw/webpack-bundle-analyzer:optimize-install-size: