fix: limit progress bar length to 40 when no columns provided#9815
Closed
haoqunjiang wants to merge 2 commits intowebpack:mainfrom
Closed
fix: limit progress bar length to 40 when no columns provided#9815haoqunjiang wants to merge 2 commits intowebpack:mainfrom
haoqunjiang wants to merge 2 commits intowebpack:mainfrom
Conversation
Contributor
|
For maintainers only:
|
sokra
approved these changes
Aug 12, 2020
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the comment here: #9225 (comment)
There are several cases where
process.stderr.columnscould beundefined. Like, in the Vue CLI UI console, or in a CI log page. But that doesn't mean there's infinity room to display the lines. In these cases, we should fall back to the old behavior of the40max length.What kind of change does this PR introduce?
A bugfix
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Nothing.