fix(require.ensure): add ArrowFunctionExpression support: Fixes #959 #3544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokra
reviewed
Dec 21, 2016
| }); | ||
|
|
||
| it("should parse a string in require.ensure with arrow function expression", function(done) { | ||
| require.ensure("./file", require => { |
Member
There was a problem hiding this comment.
Could you also add a test with a single expression array function? They behave a bit different in AST.
require.ensure("./file", require => (require("./file").should.be.eql("ok"), done()))
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix. Fixes #959
require.ensurewas erroring when passing arrow function as callback.import()Did you add tests for your changes?
Yes
If relevant, link to documentation update:
N/A
Summary
Does this PR introduce a breaking change?
No
Other information