Enable to update entry during watch mode#3354
Closed
nkzawa wants to merge 2 commits intowebpack:masterfrom
Closed
Conversation
|
|
nkzawa
commented
Nov 22, 2016
| return "multi " + this.name; | ||
| return "multi " + this.dependencies.map(function(d) { | ||
| return path.resolve(this.context, d.request); | ||
| }.bind(this)).join('!'); |
Contributor
Author
There was a problem hiding this comment.
This change is required because entry might be changed to have a same name with different dependencies.
Member
|
Instead of making this PR, make a PR that allows the This could be done by adding a 3rd branch to the EntryOptionPlugin and introducing a new DynamicEntryPlugin which handles this. Because this plugin may need to reuse some code from SingleEntryPlugin and MultiEntryPlugin, you could move this code into static functions and call them from your new plugin. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
No, because
If relevant, did you update the documentation?
No
Summary
This PR enables to add/remove
entryduring watch mode.Related: #2874
Does this PR introduce a breaking change?
Maybe no.
Other information
This PR is based on our work for next.js