Skip to content

feat: add universal target preset (browser + web worker + Node.js + Electron + NW.js)#21214

Merged
alexander-akait merged 5 commits into
mainfrom
claude/universal-target-webpack-tests-69q1lq
Jun 18, 2026
Merged

feat: add universal target preset (browser + web worker + Node.js + Electron + NW.js)#21214
alexander-akait merged 5 commits into
mainfrom
claude/universal-target-webpack-tests-69q1lq

Conversation

@alexander-akait

Copy link
Copy Markdown
Member

Summary

Adds a dedicated universal target preset so users can write target: "universal" instead of target: ["web", "node"]. The preset merges web + web worker + node + electron + nwjs platform features, always outputs ECMAScript modules (it defaults experiments.outputModule to true, since universal only works as ESM), and never exposes synchronous CommonJS require. It resolves to a static property literal (no per-lookup merge). Also adds a large configCases/target/universal-all-module-types case that exercises (almost) every module/asset type webpack supports — run under node, web, and universal, where the universal bundle executes once in a node-like and once in a web-like environment.

What kind of change does this PR introduce?

feat

Did you add tests for your changes?

Yes — test/configCases/target/universal-all-module-types/* (ESM, CommonJS, JSON, deferred/source-phase imports, dynamic import + context, top-level await, externals, all CSS variants, HTML, async WASM, workers, and every asset module type incl. type: text/type: bytes), and a target: "universal" snapshot in test/Defaults.unittest.js.

Does this PR introduce a breaking change?

No. target: "universal" is new; existing targets are unchanged. Defaulting experiments.outputModule for universal only affects configs that previously errored at chunk-format selection.

If relevant, what needs to be documented once your changes are merged or what have you already documented?

The new target: "universal" value (browser + web worker + Node.js + Electron + NW.js, ESM-only). Known limitation to note in docs: live CSS hot-updates do not apply on the Node side of a universal build (no document → no-op); JS module HMR works in both environments.

Use of AI

AI (Claude Code) was used to research the existing universal-target handling, implement the preset and defaults wiring, author the comprehensive test case, and iterate until the suites passed. All changes were reviewed and verified locally.


Generated by Claude Code

…test

Add a dedicated `universal` target that merges `web` and `node` features,
so users can write `target: "universal"` instead of `target: ["web", "node"]`.

Add a comprehensive configCase exercising most module types webpack supports
(esm, commonjs, json, deferred imports, source-phase imports, externals,
dynamic import, top-level await, asset modules, css + css modules, html, wasm,
workers) run under node, web and the universal target.

Update the test runner to expand the `universal` preset to web + node when
running universal bundles once per environment.
Expand the `universal` preset to merge web + webworker + node so it also
covers Web Worker environments (previously `webworker` was `false`), and have
it always declare ECMAScript module support.

Default `experiments.outputModule` to true for universal targets: the target
only works as ESM, so `target: "universal"` now builds out of the box instead
of failing chunk-format selection.
The universal preset resolved its properties by calling getTargetProperties
for web/webworker/node and merging on every lookup. Replace that with the
equivalent static literal (byte-identical result).
…equire

Extend the universal preset to span Electron (all contexts) and NW.js in
addition to browser, web worker and Node.js, so it externalizes the matching
built-ins. Since universal output is always ESM, set `require` (synchronous
CommonJS require) to false; node built-ins and `global` stay ambiguous (null)
because they remain available under Node.js ESM.
Add the remaining asset cases to the comprehensive universal test: asset/bytes,
auto asset, and the `type: text` / `type: bytes` import attributes, plus
css/global and import.meta.webpackContext.

Add a per-config environment assertion; the universal config executes the same
bundle in both a node-like and a web-like environment.
@changeset-bot

changeset-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8878879

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
webpack Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

This PR is packaged and the instant preview is available (4b00f6e).

Install it locally:

  • npm
npm i -D webpack@https://pkg.pr.new/webpack@4b00f6e
  • yarn
yarn add -D webpack@https://pkg.pr.new/webpack@4b00f6e
  • pnpm
pnpm add -D webpack@https://pkg.pr.new/webpack@4b00f6e

@github-actions

Copy link
Copy Markdown
Contributor

Types Coverage

Coverage after merging claude/universal-target-webpack-tests-69q1lq into main will be
99.35%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
bin
   webpack.js98.77%100%100%98.77%91
examples
   build-common.js100%100%100%100%
   buildAll.js100%100%100%100%
   examples.js100%100%100%100%
   template-common.js98.21%100%100%98.21%72
examples/custom-javascript-parser
   test.filter.js100%100%100%100%
examples/custom-javascript-parser/internals
   acorn-parse.js100%100%100%100%
   meriyah-parse.js100%100%100%100%
   oxc-parse.js91.30%100%100%91.30%140, 142–143, 145, 147, 153–154, 161, 168, 90
examples/markdown
   webpack.config.mjs100%100%100%100%
examples/typescript
   test.filter.js100%100%100%100%
examples/typescript-non-erasable
   test.filter.js50%100%100%50%5
examples/virtual-modules
   test.filter.js100%100%100%100%
examples/wasm-bindgen-esm
   test.filter.js100%100%100%100%
examples/wasm-complex
   test.filter.js100%100%100%100%
examples/wasm-simple
   test.filter.js100%100%100%100%
examples/wasm-simple-source-phase
   test.filter.js100%100%100%100%
lib
   APIPlugin.js100%100%100%100%
   AsyncDependenciesBlock.js100%100%100%100%
   AutomaticPrefetchPlugin.js100%100%100%100%
   BannerPlugin.js100%100%100%100%
   Cache.js98.21%100%100%98.21%101
   CacheFacade.js100%100%100%100%
   Chunk.js99.72%100%100%99.72%39
   ChunkGraph.js100%100%100%100%
   ChunkGroup.js100%100%100%100%
   ChunkTemplate.js100%100%100%100%
   CleanPlugin.js99.15%100%100%99.15%206, 226
   CodeGenerationResults.js100%100%100%100%
   CompatibilityPlugin.js100%100%100%100%
   Compilation.js98.43%100%100%98.43%1618, 1937, 1944, 1952, 1974, 1977, 2917, 3396–3397, 3429, 4093, 4123, 4176–4177, 4181, 4186, 4202–4203, 4217–4218, 4223–4224, 4701, 4727, 514, 519, 5535, 5567, 5584, 5600, 5616, 5631, 5656–5657, 5659, 5987, 5992, 5998, 6001, 6013, 6015, 6019, 6035, 6050, 6082, 6136, 6160, 6274, 764–765
   Compiler.js99.56%100%100%99.56%1135–1136, 1144
   ConcatenationScope.js98.59%100%100%98.59%189
   ConditionalInitFragment.js100%100%100%100%
   ConstPlugin.js100%100%100%100%
   ContextExclusionPlugin.js100%100%100%100%
   ContextModule.js100%100%100%100%
   ContextModuleFactory.js97.40%100%100%97.40%258, 395, 418, 420, 424, 433–434
   ContextReplacementPlugin.js100%100%100%100%
   DefinePlugin.js99%100%100%99%171–172, 188, 207, 281
   DependenciesBlock.js100%100%100%100%
   Dependency.js98.28%100%100%98.28%425, 471
   DependencyTemplate.js100%100%100%100%
   DependencyTemplates.js100%100%100%100%
   DotenvPlugin.js98.41%100%100%98.41%378, 391–392
   DynamicEntryPlugin.js100%100%100%100%
   EntryOptionPlugin.js100%100%100%100%
   EntryPlugin.js100%100%100%100%
   Entrypoint.js100%100%100%100%
   EnvironmentPlugin.js97.14%100%100%97.14%49
   ErrorHelpers.js100%100%100%100%
   EvalDevToolModulePlugin.js100%100%100%100%
   EvalSourceMapDevToolPlugin.js100%100%100%100%
   ExportsInfo.js100%100%100%100%
   ExportsInfoApiPlugin.js100%100%100%100%
   ExternalModule.js98.50%100%100%98.50%1057, 1060, 445–449, 451, 597
   ExternalModuleFactoryPlugin.js100%100%100%100%
   ExternalsPlugin.js100%100%100%100%
   FileSystemInfo.js99.50%100%100%99.50%182, 2252–2253, 2256, 2267, 2278, 2289, 278, 3693, 3708, 3732
   FlagAllModulesAsUsedPlugin.js100%100%100%100%
   FlagDependencyExportsPlugin.js98.46%100%100%98.46%425, 434, 436, 440
   FlagDependencyUsagePlugin.js100%100%100%100%
   FlagEntryExportAsUsedPlugin.js100%100%100%100%
   Generator.js100%100%100%100%
   HotModuleReplacementPlugin.js100%100%100%100%
   HotUpdateChunk.js100%100%100%100%
   IgnorePlugin.js100%100%100%100%
   IgnoreWarningsPlugin.js100%100%100%100%
   InitFragment.js100%100%100%100%
   JavascriptMetaInfoPlugin.js100%100%100%100%
   LazyBarrel.js100%100%100%100%
   LibraryTemplatePlugin.js100%100%100%100%
   LoaderOptionsPlugin.js100%100%100%100%
   LoaderTargetPlugin.js100%100%100%100%
   MainTemplate.js100%100%100%100%
   ManifestPlugin.js100%100%100%100%
   Module.js98.50%100%100%98.50%1285, 1290, 1350, 1364, 1426, 1435
   ModuleFactory.js100%100%100%100%
   ModuleFilenameHelpers.js98.85%100%100%98.85%106, 108
   ModuleGraph.js99.73%100%100%99.73%1005
   ModuleGraphConnection.js100%100%100%100%
   ModuleInfoHeaderPlugin.js100%100%100%100%
   ModuleNotFoundError.js100%100%100%100%
   ModuleProfile.js100%100%100%100%
   ModuleSourceTypeConstants.js100%100%100%100%
   ModuleTemplate.js100%100%100%100%
   ModuleTypeConstants.js100%100%100%100%
   MultiCompiler.js99.69%100%100%99.69%659
   MultiStats.js100%100%100%100%
   MultiWatching.js100%100%100%100%
   NoEmitOnErrorsPlugin.js100%100%100%100%
   NodeStuffPlugin.js100%100%100%100%
   NormalModule.js97.90%100%100%97.90%1240, 1243, 1260, 1277, 1524, 1558, 1574, 1661, 2017, 2316, 2321–2331, 419, 423, 577
   NormalModuleFactory.js99.47%100%100%99.47%1083, 1392, 486, 498
   NormalModuleReplacementPlugin.js100%100%100%100%
   NullFactory.js100%100%100%100%
   OptimizationStages.js100%100%100%100%
   OptionsApply.js100%100%100%100%
   Parser.js100%100%100%100%
   PlatformPlugin.js100%100%100%100%
   PrefetchPlugin.js100%100%100%100%
   ProgressPlugin.js98.85%100%100%98.85%519–520, 525, 527, 591
   ProvidePlugin.js100%100%100%100%
   RawModule.js100%100%100%100%
   RecordIdsPlugin.js100%100%100%100%
   RequestShortener.js100%100%100%100%
   ResolverFactory.js100%100%100%100%
   RuntimeGlobals.js100%100%100%100%
   RuntimeModule.js100%100%100%100%
   RuntimePlugin.js100%100%100%100%
   RuntimeTemplate.js100%100%100%100%
   SelfModuleFactory.js100%100%100%100%
   SingleEntryPlugin.js100%100%100%100%
   SourceMapDevToolModuleOptionsPlugin.js100%100%100%100%
   SourceMapDevToolPlugin.js98.62%100%100%98.62%220, 224, 226, 419, 430, 891
   Stats.js100%100%100%100%
   Template.js100%100%100%100%
   TemplatedPathPlugin.js99.17%100%100%99.17%176–177
   UseStrictPlugin.js100%100%100%100%
   WarnCaseSensitiveModulesPlugin.js100%100%100%100%
   WarnDeprecatedOptionPlugin.js100%100%100%100%
   WarnNoModeSetPlugin.js100%100%100%100%
   WatchIgnorePlugin.js100%100%100%100%
   Watching.js100%100%100%100%
   WebpackError.js100%100%100%100%
   WebpackIsIncludedPlugin.js100%100%100%100%
   WebpackOptionsApply.js100%100%100%100%
   WebpackOptionsDefaulter.js100%100%100%100%
   buildChunkGraph.js99.87%100%100%99.87%371
   cli.js98.62%100%100%98.62%10, 119, 545, 577, 627, 897
   index.js99.72%100%100%99.72%184
   validateSchema.js94.67%100%100%94.67%100, 87, 89, 98
   webpack.js96.33%100%100%96.33%10, 198, 220, 222
lib/asset
   AssetBytesGenerator.js100%100%100%100%
   AssetBytesParser.js100%100%100%100%
   AssetGenerator.js100%100%100%100%
   AssetModule.js100%100%100%100%
   AssetModulesPlugin.js97.32%100%100%97.32%281, 305, 308, 36, 360, 41
   AssetParser.js100%100%100%100%
   AssetSourceGenerator.js100%100%100%100%
   AssetSourceParser.js100%100%100%100%
   RawDataUrlModule.js100%100%100%100%
lib/async-modules
   AsyncModuleHelpers.js100%100%100%100%
   AwaitDependenciesInitFragment.js100%100%100%100%
   InferAsyncModulesPlugin.js100%100%100%100%
lib/cache
   AddBuildDependenciesPlugin.js100%100%100%100%
   AddManagedPathsPlugin.js100%100%100%100%
   IdleFileCachePlugin.js97.92%100%100%97.92%71, 83, 91
   MemoryCachePlugin.js95.83%100%100%95.83%33
   MemoryWithGcCachePlugin.js93.15%100%100%93.15%106, 113–114, 122, 89
   PackFileCacheStrategy.js96.40%100%100%96.40%1250, 1350, 1354, 1416, 628, 647, 657–659, 661, 677–678, 683, 686, 688, 693, 698, 722, 728, 762, 768, 774, 779, 790, 799, 804–805, 807, 824, 830–831, 833
   ResolverCachePlugin.js100%100%100%100%
   getLazyHashedEtag.js100%100%100%100%
   mergeEtags.js100%100%100%100%
lib/config
   browserslistTargetHandler.js100%100%100%100%
   defaults.js99.31%100%100%99.31%1444–1446, 1454, 274, 277, 282, 286
   defineConfig.js100%100%100%100%
   normalization.js99.01%100%100%99.01%191–192, 258, 273
   target.js100%100%100%100%
lib/container
   

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.75%. Comparing base (6e43ab8) to head (8878879).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21214      +/-   ##
==========================================
+ Coverage   92.74%   92.75%   +0.01%     
==========================================
  Files         591      591              
  Lines       64304    64334      +30     
  Branches    17863    17877      +14     
==========================================
+ Hits        59641    59676      +35     
+ Misses       4663     4658       -5     
Flag Coverage Δ
css-parsing 28.69% <60.00%> (-0.01%) ⬇️
html5lib 31.16% <60.00%> (-0.01%) ⬇️
integration 88.71% <100.00%> (+0.01%) ⬆️
test262 45.48% <60.00%> (+<0.01%) ⬆️
unit 41.10% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hq Bot commented Jun 18, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 50.86%

⚡ 2 improved benchmarks
❌ 2 regressed benchmarks
✅ 140 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory benchmark "lodash", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 125.1 KB 859.1 KB -85.44%
Memory benchmark "asset-modules-inline", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 327 KB 1,294.7 KB -74.74%
Memory benchmark "asset-modules-bytes", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 321.2 KB 248 KB +29.52%
Memory benchmark "many-modules-esm", scenario '{"name":"mode-production","mode":"production"}' 9.9 MB 8.1 MB +22.43%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing claude/universal-target-webpack-tests-69q1lq (8878879) with main (2b7d64e)

Open in CodSpeed

@alexander-akait alexander-akait merged commit 4b00f6e into main Jun 18, 2026
67 checks passed
@alexander-akait alexander-akait deleted the claude/universal-target-webpack-tests-69q1lq branch June 18, 2026 12:44
@alexander-akait alexander-akait restored the claude/universal-target-webpack-tests-69q1lq branch June 18, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant