fix: correctly parse '#' in absolute path directory names (fixes #16819)#20877
Closed
shayannab wants to merge 2 commits into
Closed
fix: correctly parse '#' in absolute path directory names (fixes #16819)#20877shayannab wants to merge 2 commits into
shayannab wants to merge 2 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following enhanced-resolve#473 which introduced the
\0#escape workaround, this PR implements automatic detection for#in absolute paths to resolve #16819.The Problem
When a project is located in a directory containing
#(e.g./home/user/test#project/orC:\my#project\), webpack incorrectly treats#as a fragment identifier, causing resolution failures andUnhandledSchemeError.The Fix
In
_parseResource, if the path is absolute and a/or\exists after the#before any query string, the#is treated as part of the directory name. Fragments cannot have path separators after them, so this detection is mathematically sound.Tests Added
#in directory name#in directory name#directory#fragments unchanged