fix: expose exports from all entry modules in library output#20731
Open
sujalgoel wants to merge 1 commit intowebpack:mainfrom
Open
fix: expose exports from all entry modules in library output#20731sujalgoel wants to merge 1 commit intowebpack:mainfrom
sujalgoel wants to merge 1 commit intowebpack:mainfrom
Conversation
When using array entry with output.library, only the last entry's exports were accessible on the library object. Loop over all entry deps in AbstractLibraryPlugin and share the same __webpack_exports__ object across all inlined entry modules so every export is merged into the library. Fixes webpack#15936
🦋 Changeset detectedLatest commit: eb214cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15936
When using an array entry with
output.library, only the last entry module's exports were accessible on the library object. The remaining entry modules had their exports silently discarded.Root cause
Two separate issues:
AbstractLibraryPlugin(lib/library/AbstractLibraryPlugin.js):finishEntryModulewas only called for the last dependency in the entry deps array instead of all of them.JavascriptModulesPlugin(lib/javascript/JavascriptModulesPlugin.js): Non-last inlined entry modules were given an isolated{}as theirexportsArgument, so their exports never merged into__webpack_exports__. With a library config and multiple entries, all entry modules now share the same__webpack_exports__object.Fix
AbstractLibraryPlugin.finishEntryModulemergeLibraryEntryExportsflag — when a library is configured with multiple entries, all inlined entry modules shareRuntimeGlobals.exportsinstead of{}Test
Added
test/configCases/library/issue-15936/which bundles three entry files (a.js,b.js,c.js) withoutput.library: { type: "assign", name: "MultiEntryLib" }and asserts that exports from all three are present on the global library object.