feat: support import specifier guard#20320
Merged
alexander-akait merged 6 commits intomainfrom Feb 2, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 01cdc18 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This PR is packaged and the instant preview is available (cd4793d). Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@cd4793d
yarn add -D webpack@https://pkg.pr.new/webpack@cd4793d
pnpm add -D webpack@https://pkg.pr.new/webpack@cd4793d |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
Member
alexander-akait
left a comment
There was a problem hiding this comment.
Looks very good, let's
- rebase main, because I see some problems style of with jsdocs types (we recently apply eslint rule for this)
- let's merge
HarmonyImportSpecifierGuardParserPluginandHarmonyImportDependencyParserPlugininto oneHarmonyImportDependencyParserPluginplugin, just create private method and put this logic here, we don't use it somewhere else so no need an extrarequirecall and putting the code into own file, since their logic is very closely related and dependent on each other
Member
|
Also let's add changesets log |
8ed0c1e to
a22079f
Compare
Member
Author
|
Thanks for the review. Please take another look. |
alexander-akait
approved these changes
Feb 2, 2026
This was referenced Feb 3, 2026
This was referenced Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14814 and closes #15497.
What kind of change does this PR introduce?
Support import specifier guard detection.
For example:
We will firstly walk
expressioninIfStatement.test(the same as forConditionalExpression) to collect import specifier guards which will be tagged to theharmonySpecifierTagvariable. Then, while walk bothIfStatement.testand theIfStatement.consequent(the same as forConditionalExpression), we visit these guards to determine whether the export is present at runtime.Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No