fix: node async wasm loader generation #19210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node async wasm loader was incorrectly using output.environment.module to determine if import statement should be used. Which may not match the output flavor defined by output.module.
The committers listed above are authorized under a signed CLA. |
alexander-akait
approved these changes
Feb 10, 2025
Contributor
Author
|
@alexander-akait may I ask when this will be released? |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node async wasm loader was incorrectly using output.environment.module
to determine if import.meta statement should be used. Which may not match
the output flavor defined by output.module.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
no
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
no
Fixes #19209