test: fix import attributes external target#18981
Merged
alexander-akait merged 1 commit intowebpack:mainfrom Nov 15, 2024
Merged
test: fix import attributes external target#18981alexander-akait merged 1 commit intowebpack:mainfrom
alexander-akait merged 1 commit intowebpack:mainfrom
Conversation
Contributor
|
For maintainers only:
|
alexander-akait
approved these changes
Nov 14, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Previously, the bundled result of
test/js/ConfigTestCases/externals/import-attributes/bundle0.mjswas incorrect as below. It should be./pkg.jsonbecause ESM requires a fully specified path.I'm not sure the reason it's not panicked in webpack test, as webpack test is simulating many stuff like the runtime. But it did panic in Rspack ported webpack test (they're not fully aligned). However, according to the output code, it should be fixed this way.
Did you add tests for your changes?
Yes.
Does this PR introduce a breaking change?
No.
What needs to be documented once your changes are merged?
No.