fix: hotUpdate chunk modified with new runtime should have correct runtime#18901
Merged
alexander-akait merged 1 commit intowebpack:mainfrom Oct 30, 2024
Merged
fix: hotUpdate chunk modified with new runtime should have correct runtime#18901alexander-akait merged 1 commit intowebpack:mainfrom
alexander-akait merged 1 commit intowebpack:mainfrom
Conversation
Contributor
|
For maintainers only:
|
aa43b11 to
03f8bf7
Compare
2 tasks
Member
|
@JSerFeng Is it ready to review/merge? |
Contributor
Author
|
Done |
alexander-akait
approved these changes
Oct 30, 2024
Member
|
Thank you! Good catch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Initial compile we have only entry runtime, and we split a module 'lib' into separate chunk, then we modify some of entry module, make it imports a worker, the worker contains the module 'lib' as well.
We have 2 runtime: entry and worker
if one module exist both in entry and worker, and we split it into separate chunk, the chunk has runtime entry and worker, but the HotUpdate chunk only have runtime in the previous compilation, which is entry only, so it cannot render module 'lib', because 'lib' is generated using runtime entry + worker
For the detailed repro, you could check my test case
Did you add tests for your changes?
Yes.
Does this PR introduce a breaking change?
What needs to be documented once your changes are merged?