Skip to content

ci: add Node.js v23 #18891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snitin315 wants to merge 2 commits into from
Closed

ci: add Node.js v23 #18891

snitin315 wants to merge 2 commits into from

Conversation

@snitin315
Copy link
Member

@snitin315 snitin315 commented Oct 25, 2024

What kind of change does this PR introduce?
CI

Run tests on Node.js v23

Did you add tests for your changes?
NA

Does this PR introduce a breaking change?
No

What needs to be documented once your changes are merged?
Nothing

@webpack-bot
Copy link
Contributor

webpack-bot commented Oct 25, 2024

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@snitin315
Copy link
Member Author

snitin315 commented Oct 28, 2024

Looking intointegration (ubuntu-latest, 23.x, b)

@alexander-akait
Copy link
Member

alexander-akait commented Oct 30, 2024

@snitin315 Looks like regression in Node.js, - fs.readFile("/", (err) => {}), before err.code === "EISDIR", now no callback call and err.code === "ERR_FS_EISDIR"

@alexander-akait alexander-akait mentioned this pull request Oct 30, 2024
Closed
@alexander-akait
Copy link
Member

alexander-akait commented Oct 30, 2024

Ref: nodejs/node#55609

@juanarbol juanarbol mentioned this pull request Oct 31, 2024
Merged
@snitin315 snitin315 mentioned this pull request Nov 5, 2024
Closed
@evenstensberg
Copy link
Member

evenstensberg commented Nov 8, 2024

Are we still blocked from the node regression? What does it need to fix this?

@alexander-akait alexander-akait mentioned this pull request Nov 13, 2024
Merged
@alexander-akait
Copy link
Member

alexander-akait commented Nov 13, 2024

Close in favor - #18972

@alexander-akait alexander-akait deleted the snitin315-patch-1 branch November 13, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: unreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@snitin315 @webpack-bot @alexander-akait @evenstensberg